Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16858 to 7.x: [libbeat] Document / clean up parts of the publisher queue interface #16897

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Cherry-pick #16858 to 7.x: [libbeat] Document / clean up parts of the publisher queue interface #16897

merged 1 commit into from
Mar 9, 2020
+41 −40

Conversation

faec
Copy link
Contributor

@faec faec commented Mar 9, 2020 •
edited by andresrc
Loading

Cherry-pick of PR #16858 to 7.x branch. Original message:

What does this PR do?

This PR does a few documentation / cleanup tasks:

  • documents the expected behavior for the abstract queue.Producer and queue.Consumer interfaces
  • removes the unused field openState.isOpen
  • renames the boolean flag ackProducer.cancel to ackProducer.dropOnCancel

This PR introduces no user-visible changes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@faec faec requested a review from urso March 9, 2020 12:30
@faec faec merged commit e71dee2 into elastic:7.x Mar 9, 2020
@faec faec deleted the backport_16858_7.x branch March 9, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faec @urso